PoC pagination reset#779
Closed
Maxime Carbonneau-Leclerc (maxi297) wants to merge 1 commit into
Closed
Conversation
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. Testing This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@maxi297/poc_pagination_reset#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch maxi297/poc_pagination_resetHelpful ResourcesPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
PyTest Results (Fast)1 tests - 3 777 0 ✅ - 3 766 3s ⏱️ - 6m 31s For more details on these errors, see this check. Results for commit 7dcbc04. ± Comparison against base commit 7ab013d. This pull request removes 3778 and adds 1 tests. Note that renamed tests count towards both. |
PyTest Results (Full)2 tests - 3 779 0 ✅ - 3 769 14s ⏱️ - 10m 50s For more details on these errors, see this check. Results for commit 7dcbc04. ± Comparison against base commit 7ab013d. This pull request removes 3781 and adds 2 tests. Note that renamed tests count towards both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
https://docs.google.com/document/d/14Rk-eziI78h4bMYyvZLmuWY2Fd4SwAglRElR3XR2NiU/edit?tab=t.0
How
Add a ResponseAction to trigger an exception that needs to be handled by those doing pagination (in this case, it is the SimpleRetriever). When this is done, call the cursor to try to regenerate the stream slice.
TODO:
reduce_slice_rangeon it and build the StreamSlice accordinglyResponseActiontype to the modelTo test, I'm using the following manifest for stream
ticketsfrom source-freshdesk without the custom components. Note that I've changed the paginationstart_fromto 300.I'm having this output:
Manifest: